Now I've also twisted some shoulders out of joint. Not that the toons usually complain.
The shoulders' rotations and weight painting look good all in all. There were just two minor details in weight painting I thought I'll point out so it looks as if I'm doing anything useful.
When rotating arm so it point downwards, I think there should be a compensation on the outside of the shoulder: It should bulge out a bit. To me, the current weight makes it look a bit flattened:
That's a pretty minor issue though, and maybe it's just me.
When rotating arm forward into the picture, there's a slight bulge/candywrap on top of the shoulder that might be polished:
Again, a rather minor issue.